- 
                Notifications
    
You must be signed in to change notification settings  - Fork 226
 
Testing MacOS release Validation Automation #1102
Conversation
5d8ff1e    to
    8480824      
    Compare
  
    | 
           link: pytorch/pytorch#83013  | 
    
ab9b1e6    to
    fbec713      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though can you please extract as much logic from .yml into .py file (so that other people would not have to duplicate the behaviour)
db8eb5a    to
    b661426      
    Compare
  
    1745d9e    to
    bea4236      
    Compare
  
    | 
           this PR needs to be updated once pytorch/test-infra#654 is merged.  | 
    
| uses: actions/checkout@v3 | ||
| with: | ||
| ref: weiwangmeta/testing_macos_nightly_wheels | ||
| - name: Install Fresh Miniconda in Runner Temp Dir | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have the setup-miniconda action now from the test-infra repository that should cover this functionality
| 
           All comments addressed, please review again, thank you!  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We probably want to align Linux and MacOS jobs by moving composite to actions but can be done in followup PR
On a ARM based MacOS, download miniconda, create conda env, install pytorch, and do import pytorch.